]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Use of ast for integers doesn't changes type
authorSean McCully <sean_mccully@yahoo.com>
Thu, 10 Sep 2015 20:33:37 +0000 (16:33 -0400)
committerSean McCully <sean_mccully@yahoo.com>
Tue, 22 Sep 2015 01:35:41 +0000 (21:35 -0400)
commit96cacc6225a3fe48d06e0e41d6e74e6af1595f7f
tree344b8328b6179814d87cb65fda5147032a692994
parent033de65a46b551fef6934ff2a1931df8390f6910
Use of ast for integers doesn't changes type

ast.literal_eval doesn't change types for Integer
Booleans resulting in DBAPIError exceptions with
at least postgresql. Boolean columns need to be
explicitly cast to boolean types. This changes
the way filters are processed in the volume API.

APIImpact
Change-Id: Ice9c57fa99c17e4c87de6362bf30ed30503a1bed
Closes-Bug: #1494475
cinder/api/v2/volumes.py
cinder/db/api.py
cinder/db/sqlalchemy/api.py
cinder/tests/unit/api/v2/test_volumes.py
cinder/volume/api.py