]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
replace use of dhcp_lease_time with dhcp_lease_duration
authorDarren Birkett <darren.birkett@gmail.com>
Wed, 19 Jun 2013 12:37:02 +0000 (12:37 +0000)
committerDarren Birkett <darren.birkett@gmail.com>
Thu, 20 Jun 2013 11:04:40 +0000 (11:04 +0000)
commit95dbd03a0bc4867bf8520539ed08f4068adf2f33
tree891807895e3c66b1ccfa26ac3096ae74d3c12df0
parent8eea1ae574671a157ae2d215f18635a3c8985a06
replace use of dhcp_lease_time with dhcp_lease_duration

Having 2 separate dhcp lease period flags (dhcp_lease_duration
used by the quantum db plugin, and dhcp_lease_time used by the
dnsmasq dhcp agent) means that you could potentially have different
lease periods being set, and used by different parts of the codebase.

It seems to me there is no real need to have 2 separate flags, so this
commit basically replaces references to dhcp_lease_time (which is used
by the dnsmasq dhcpagent) with dhcp_lease_duration. This way, there
is only one flag to set, and both the quantum db plugin and dnsmasq
dhcp agent will use the same lease period.

Change-Id: Ia99dfa9284b6e737144f61a80c59cd898c0949bb
Fixes: bug #1192550
quantum/agent/dhcp_agent.py
quantum/agent/linux/dhcp.py
quantum/common/config.py
quantum/tests/unit/test_linux_dhcp.py