]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix iscsi_write_cache setting for iscsi targets
authorJohn Griffith <john.griffith@solidfire.com>
Wed, 7 Jan 2015 05:47:01 +0000 (22:47 -0700)
committerJohn Griffith <john.griffith@solidfire.com>
Fri, 9 Jan 2015 19:25:17 +0000 (12:25 -0700)
commit942981cdd3627c3ccd5dfe5db463f4ee2ccc73cb
treea804e5ae3f2f9e5583091fda3767744c1acdb85f
parent9742b7d3611aa6eece0abc3c6479290a825b5c40
Fix iscsi_write_cache setting for iscsi targets

While transitioning to the new driver and target
model (change 9651f547147188645942466602c92cce06666483)
some things got lost not surprisingly.  One of those
things that wasn't migrated correctly was the
iscsi_write_cache option due to ensure_export not
being called properly on service restart.

This patch cleans up the ensure/create_export methods
and their signatures.  Most importantly esnure_export
should now actually work and check the iscsi_write_cache
settings.

While fixing this I also cleaned up the two methods
mentioned above to eliminate the unnecessary and
duplicate info in their arguments.

Closes-Bug: #1408171

Change-Id: Ibfd1feefd72c43ef316b267e9d6645f2e67e2558
cinder/volume/drivers/block_device.py
cinder/volume/drivers/drbdmanagedrv.py
cinder/volume/drivers/lvm.py
cinder/volume/drivers/srb.py
cinder/volume/targets/driver.py
cinder/volume/targets/fake.py
cinder/volume/targets/iet.py
cinder/volume/targets/iser.py
cinder/volume/targets/lio.py
cinder/volume/targets/tgt.py