]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Do not require sudo/rootwrap to check for dnsmasq version
authorarmando-migliaccio <amigliaccio@nicira.com>
Fri, 10 May 2013 20:10:02 +0000 (13:10 -0700)
committerarmando-migliaccio <amigliaccio@nicira.com>
Fri, 10 May 2013 21:12:18 +0000 (14:12 -0700)
commit91b56e41eecf2cd8b4c848b4e773a1be307b40c3
treeadf4b0f2e0122319810d11ebde135ae7cadfc116
parent21575de9d3134feb84e6da83edba966c90145c45
Do not require sudo/rootwrap to check for dnsmasq version

The dnsmasq version check does not need root privileges
to run as with low privs it works just fine. As a side
effect, the use of the rootwrapper was causing unit tests
to hung because the execute call in check_version was not
being stubbed out. Weirdly enough this wasn't caught in
a previous Gerrit run; there must be a passwordless sudo
lurking around somewhere in the Gerrit infrastructure.

Fixes bug #1178800

Change-Id: I4d0bd218768eec2439d3907587682ff35884a262
etc/quantum/rootwrap.d/dhcp.filters
quantum/agent/dhcp_agent.py
quantum/agent/linux/dhcp.py
quantum/rootwrap/filters.py
quantum/tests/unit/test_linux_dhcp.py