]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Do not mark device as processed if it wasn't
authorSalvatore Orlando <salv.orlando@gmail.com>
Sat, 5 Jul 2014 16:17:54 +0000 (09:17 -0700)
committerSalvatore Orlando <salv.orlando@gmail.com>
Tue, 8 Jul 2014 15:24:15 +0000 (08:24 -0700)
commit90fedbe44ca6bfccce5d71465532fbdc85ee3814
tree5d8064bb58b8a05e604c66bd6da40d911cfafdcf
parent74daab5de36141b9662c120956cd442fc867ed3c
Do not mark device as processed if it wasn't

Currently treat_devices_added_or_updated in the OVS agent skips
processing devices which disappeared from the integration bridge
during the agent loop.
This is fine, however the agent should not mark these devices as
processed. Otherwise they won't be processed, should they appear
again on the bridge.

This patch ensures these devices are not added to the current
device set.

The patch also changes treat_devices_added_or_updated. The
function now will return the list of skipped devices and not
anymore a flag signalling whether a resync is required.
With the current logic a resync would be required if retrieval
of device details fails. With this change, the function
treat_devices_added_or_updated will raise in this case and the
exception will be handled in process_network_ports.

For the sake of consistency, this patch also updates the
similar function treat_ancillary_devices_added in order to
use the same logic.

Finally, this patch amends an innaccurate related comment.

Closes-Bug: #1329546

Change-Id: Icc744f32494c7a76004ff161536316924594fbdb
neutron/plugins/openvswitch/agent/ovs_neutron_agent.py
neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py