]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Tests: Make fake_notifier per-instance
authorEric Harney <eharney@redhat.com>
Thu, 18 Jun 2015 22:06:54 +0000 (18:06 -0400)
committerGorka Eguileor <geguileo@redhat.com>
Fri, 19 Jun 2015 09:27:40 +0000 (11:27 +0200)
commit90fb6fd056ef6f424b8d35f70dee016b591fa7b7
tree06686fb2e7a81027b66cbb1e1861436d518b3e02
parentbfcc27ea5c19e8aacce95cb56c10a95c5f1373b3
Tests: Make fake_notifier per-instance

Tests have been failing because multiple threads modify the
same global NOTIFICATIONS list.  Move the notification storage
to be per-test instance, which is what the tests assume.

This has been broken for a while, but made more obvious by
recent changes to parallelize tests.

Also remove all the extra reset calls we added to work around
this problem over time.

Co-authored-by: Gorka Eguileor <geguileo@redhat.com>
Change-Id: Ib5a67c097ef548dc346751ad51b61fdceaf8e3a8
Partial-Bug: #1259463
Closes-Bug: #1412513
cinder/test.py
cinder/tests/unit/api/contrib/test_types_extra_specs.py
cinder/tests/unit/api/contrib/test_types_manage.py
cinder/tests/unit/api/contrib/test_volume_type_encryption.py
cinder/tests/unit/api/v1/test_volumes.py
cinder/tests/unit/api/v2/test_volumes.py
cinder/tests/unit/fake_notifier.py
cinder/tests/unit/test_volume.py