]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove use of keepalived 'vrrp_sync_group' as it is unused
authorYoni Shafrir <yshafrir@redhat.com>
Wed, 4 Feb 2015 05:42:13 +0000 (07:42 +0200)
committerMaru Newby <marun@redhat.com>
Tue, 10 Feb 2015 20:03:15 +0000 (20:03 +0000)
commit90df090945e9800d354c34fd03236385bff82a4e
treef66d940a16f41c4561c6944cdecb7b25a3354446
parent64bd24f9d63f679140b770eb59e196636d71926c
Remove use of keepalived 'vrrp_sync_group' as it is unused

Now keepalived configuration wraps the VRRP instances with a
'vrrp_sync_group'. The VRRP sync group functionality is only
relevant when more then one VR instance is contained in it.
In that case the VRs in the group will have the same state.
Our use of keepalived uses a single instance per router.

This patch simply removes the 'vrrp_sync_group'.
In this patch VR instances are used on their own and they now
hold the 'notify_scripts'.

Note that the same VRRP functionality is preserved with this
patch.

Another motiviation for this patch, aside from removing
useless configuration, is to lay the foundation for a future
patch that will the related bug by adding 'track_script'
that are not supported with 'vrrp_sync_group'.

Change-Id: I33b81049cd9cf140244bbf121d1a71492161c77c
Related-Bug: #1365461
neutron/agent/l3/ha_router.py
neutron/agent/linux/keepalived.py
neutron/tests/functional/agent/test_l3_agent.py
neutron/tests/unit/agent/linux/test_keepalived.py