]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove unused arguments from c-vol's create_volume
authorMichal Dulko <michal.dulko@intel.com>
Thu, 9 Jul 2015 07:05:10 +0000 (09:05 +0200)
committerMichal Dulko <michal.dulko@intel.com>
Fri, 24 Jul 2015 09:17:32 +0000 (11:17 +0200)
commit8f18900d2e42c849d627fd393c8d602f8c76ea73
treeeb58349fbe6ca1b0029a86d9de38b04b54ee95fb
parentb1d77751a3574e359fb2c0eac3b206c46b4e9e02
Remove unused arguments from c-vol's create_volume

Arguments snapshot_id, image_id, source_volid, source_replicaid,
consistencygroup_id and cgsnapshot_id in volume.rpcapi.create_volume
RPC method are duplicated either in request_spec dictionary passed as
one of the arguments or are saved into the databased and are retrieved
by flow processing the request.

To simplify the flow this commit removes these duplicated parameters
and adapts rest of the code to use occurrences that are already there.

Related-Blueprint: taskflow-refactoring
Change-Id: I4dbb57968358e8930b923275c2dfd0e44d7b40d8
cinder/scheduler/filter_scheduler.py
cinder/tests/unit/test_rbd.py
cinder/tests/unit/test_volume.py
cinder/tests/unit/test_volume_rpcapi.py
cinder/volume/flows/api/create_volume.py
cinder/volume/flows/manager/create_volume.py
cinder/volume/manager.py
cinder/volume/rpcapi.py