]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
IPAM: fix 'enable-dhcp' with internal driver
authorGary Kotton <gkotton@vmware.com>
Wed, 18 Nov 2015 16:26:18 +0000 (08:26 -0800)
committerGary Kotton <gkotton@vmware.com>
Thu, 19 Nov 2015 13:03:25 +0000 (05:03 -0800)
commit8d8444aa0ce0e6db1ebbc922311ec1eef546f2fe
treeda8b8c3bcd0a69163a08bef7bf209864c5e2eebc
parentc8a7d9bfdba9cab82cc29f563a387d8c3088c630
IPAM: fix 'enable-dhcp' with internal driver

Commit 0c1f96ad5a6606c1205bd50ea944c3a383892cde broke the ipam
internal driver. The base plugin should only call the ipam interface
and not invoke the IPallocation data model.

The code that validated that the subnet had one free IP address was
removed. This would not guarantee that a port would indeed be free,
that is, a parallel operation could have created a port on the subnet
during this check.

Closes-bug: #1514810

Change-Id: I4d7ecb985762a8eef39cb2f22f210b4899f1a22e
neutron/db/db_base_plugin_v2.py
neutron/tests/unit/db/test_db_base_plugin_v2.py