]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Change daemon Pidfile class to not use root_helper
authorBrian Haley <brian.haley@hp.com>
Tue, 27 Aug 2013 21:36:43 +0000 (17:36 -0400)
committerBrian Haley <brian.haley@hp.com>
Tue, 10 Sep 2013 17:04:14 +0000 (13:04 -0400)
commit89e38929d2bc626b639df9912a98d24b25a7e964
tree5eadcc95801d0dbd957f75c4aed844e468b7c859
parentd7855621b13ae3783f49552f5955f555f1ba2d9d
Change daemon Pidfile class to not use root_helper

Some users of the Pidfile class don't specify root_helper,
which then defaults to 'sudo', which will generate an error.
Remove root_helper altogether since we actually don't need
root priveleges to read /proc/$pid/cmdline.

Changed code to use open.readline() instead of a shell, and
tweaked tests accordingly.

Also cleaned-up the rootwrap filters that allow it as they
are not used anymore.

Fixes bug 1218142

Change-Id: I6691feb1c9f7bfa261a7ec464fd8f3f92168c302
etc/neutron/rootwrap.d/dhcp.filters
etc/neutron/rootwrap.d/lbaas-haproxy.filters
neutron/agent/linux/daemon.py
neutron/agent/linux/dhcp.py
neutron/agent/linux/external_process.py
neutron/tests/unit/test_linux_daemon.py
neutron/tests/unit/test_linux_dhcp.py
neutron/tests/unit/test_linux_external_process.py