]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Code Review / openstack-build / cinder-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 0b09f78) | patch
Handle IPv6 specifid glance servers gracefully
authorDirk Mueller <dirk@dmllr.de>
Sat, 1 Jun 2013 12:25:37 +0000 (14:25 +0200)
committerDirk Mueller <dirk@dmllr.de>
Sat, 1 Jun 2013 12:25:37 +0000 (14:25 +0200)
commit86e0125f29d863ec739db6c5eca702e03a250137
tree76c9b5455c4d121bfb2a5f0b03ea380df3617dd7tree | snapshot
parent0b09f781c60179319e08d2ecd4e986d6a6e8f3a6commit | diff
Handle IPv6 specifid glance servers gracefully

IPv6 netlocs can for valid reasons contain ':', so
splitting by ':' is dangerous. Instead of splitting
by host and port in order to only reassemble it into
a netloc again later, simply always pass netloc, which
avoids the bug.

Add extra textcases to verify the new behavior.
Fix Flake8 warnings.

Fixes LP Bug #1182830

Change-Id: I130528ae946e8888d35c25e468b4ea6ac29db0cf
cinder/image/glance.py diff | blob | history
cinder/tests/image/test_glance.py diff | blob | history