]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix broken StorPool driver
authorJohn Griffith <john.griffith8@gmail.com>
Tue, 23 Dec 2014 00:05:01 +0000 (17:05 -0700)
committerJohn Griffith <john.griffith8@gmail.com>
Wed, 24 Dec 2014 14:58:03 +0000 (07:58 -0700)
commit84431839d972a9a2339ee220e3183130cd47c11c
treeac72a53d12b75b00360b7364f2d346c119d588ae
parent86f972151eaf06b1051794c161b85e24ecfdebdc
Fix broken StorPool driver

The newly added StorPool driver has a number of issues;
It imports it's own 3'rd party libs which are not in the
requirements file, it declares conf options but never registers
them, and as a result of these two things it break the ability
to generate a configuration file.

This patch adds a try_import around the import storpool calls
like we do in other drivers, and it registers the config options
properly.

We also move the api setting out of init and into the check_setup
so the service doesn't crash if somebody tries to load the driver
without the required storpool modules.

Closes-Bug: 1405023
Closes-Bug: 1405022
Closes-Bug: 1405016
Closes-Bug: 1403532

Change-Id: I61340ab7c5abcdc21dbb12cf0693da036e69e90c
cinder/tests/test_storpool.py
cinder/volume/drivers/storpool.py