]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Ensure FC ZoneManager is called
authorWalter A. Boring IV <walter.boring@hp.com>
Thu, 19 Jun 2014 17:35:29 +0000 (10:35 -0700)
committerWalter A. Boring IV <walter.boring@hp.com>
Mon, 7 Jul 2014 23:19:03 +0000 (16:19 -0700)
commit824de4a01d424508922a9aa24293c9fbd27a8f54
treef03bd8d0a26fa1d1cda66e0167d126b578f817b1
parent776c94a8a3f49370a519e4ca92fb3071fc86e262
Ensure FC ZoneManager is called

This patch ensures that the FC ZoneManager
is called during for all cases in Cinder
that does a volume attach/detach for FC
enabled drivers.
The problem was that we had code in the volume
manager that manually called the ZoneManager,
after initialize_connection and terminate_connection,
but other places in Cinder were not calling the
ZoneManager.
This patch creates 2 new decorators that can
be used for any driver's initialize_connection
and terminate_connection call.   The decorator
checks to make sure that the return value is for
a fibre_channel attachment and then calls the
ZoneManager's add_connection or delete_connection.
Change-Id: Ie3ae70785f500a140003ad3a8495e0ddc3516ea8
Closes-Bug: 1321798
14 files changed:
cinder/tests/fake_driver.py
cinder/tests/test_volume.py
cinder/tests/zonemanager/test_fc_zone_manager.py
cinder/tests/zonemanager/test_volume_driver.py [new file with mode: 0644]
cinder/tests/zonemanager/test_volume_manager_fc.py [deleted file]
cinder/volume/drivers/emc/emc_smis_fc.py
cinder/volume/drivers/huawei/huawei_hvs.py
cinder/volume/drivers/huawei/huawei_t.py
cinder/volume/drivers/ibm/storwize_svc/__init__.py
cinder/volume/drivers/san/hp/hp_3par_fc.py
cinder/volume/drivers/san/hp/hp_msa_fc.py
cinder/volume/manager.py
cinder/zonemanager/fc_zone_manager.py
cinder/zonemanager/utils.py [new file with mode: 0644]