]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Add LC_ALL=C to lvcreate, lvextend and pvresize
authorMichal Dulko <michal.dulko@intel.com>
Tue, 25 Aug 2015 10:12:57 +0000 (12:12 +0200)
committerMichał Dulko <michal.dulko@intel.com>
Thu, 5 Nov 2015 17:43:31 +0000 (18:43 +0100)
commit81645a9ca68ad7ec4a5986925b835d28df078b4c
tree021304375f9e31bbd04850d47042ffb90b8a5056
parent7da1684f3cd5bb1d8b8763a8264d1a3ca163040a
Add LC_ALL=C to lvcreate, lvextend and pvresize

In various locales decimal mark is considered to be ',' instead of '.'.
This creates a problem when Cinder executes lvcreate, lvextend or
pvresize because it always passes numerals in 1.00g form and these
commands expect 1,00g when started with LC_NUMERIC set to one of such
locales. This commit adds LC_ALL=C env variable to all executions of
lvcreate, lvextends and pvresize and updates rootwrap's volume.filters
accordingly to make sure that parameters are interpreted in a correct
way.

Depends-On: Ie25194997b94664ec14a0f94d09c167f4fad3b4d
Change-Id: Ice7ae67f649f75cbbf2702f5f732d489ebe08aa8
Closes-Bug: 1488433
cinder/brick/local_dev/lvm.py
cinder/tests/unit/test_srb.py
cinder/volume/drivers/srb.py
etc/cinder/rootwrap.d/volume.filters
releasenotes/notes/1220b8a67602b8e7-update_rootwrap_volume_filters.yaml [new file with mode: 0644]