]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Use cinder.utils.execute directly
authorJohn Griffith <john.griffith@solidfire.com>
Wed, 7 Jan 2015 23:25:48 +0000 (16:25 -0700)
committerJohn Griffith <john.griffith@solidfire.com>
Thu, 8 Jan 2015 04:09:55 +0000 (21:09 -0700)
commit80f47322982355ff6ec6eac87e09926432bf1f3e
treee72f341a9e54a0fde3a4fef7b5fd523d5344d88f
parent941e5f761be165accaabbdeec1608189b04ab67e
Use cinder.utils.execute directly

When we were in the process of working on brick libs
we did quite a bit of funky stuff with setting a member
variable for each class to point to an executor that was
passed in during init.

There's no longer any reason to do this with the target drivers,
so we should simplify our lives a bit and go back to using the
good old cinder.utils wrapper.

It's also believed that the use of the member variable is
susceptible to some concurrency issue that was causing the
wrong cmd string to be executed.  We'll mark this as closing
that bug and reopen if we still see the signature in Kibana.

Change-Id: I7a5648d496d15eec5d7ac3643411198226f1ffdf
Closes-Bug: #1398078
cinder/tests/targets/test_base_iscsi_driver.py
cinder/tests/targets/test_tgt_driver.py
cinder/tests/test_volume.py
cinder/volume/targets/driver.py
cinder/volume/targets/iscsi.py
cinder/volume/targets/lio.py
cinder/volume/targets/tgt.py