]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Move values for network_type to plugins.common.constants.py
authorRomil Gupta <romilg@hp.com>
Mon, 23 Mar 2015 15:05:41 +0000 (08:05 -0700)
committerRomil Gupta <romilg@hp.com>
Mon, 13 Apr 2015 06:59:31 +0000 (23:59 -0700)
commit7f406805d93298d0e65d340c2a06ba0d2dd6ff76
tree69aac209fc2fd1e3715bce59b04a7e240b039cf0
parent7c46e082cdb6055660a004defcfe7abe4a343fb6
Move values for network_type to plugins.common.constants.py

It is quite confusing to have values for network type in common.constants.py
instead of having in plugins.common.constants.py.

Currently, the plugins/common/constants.py consists network_type constants
like VLAN, VXLAN, GRE etc. but values for network type like ranges
are defined in common.constants.py which is not good, it is better to have
both things at the same place.

This patch set addresses the same.

Moved out few methods which are predominantly used in plugins
from common.utils.py to plugins.common.utils.py.

Removed constants which were used in neutron-fwaas from
plugins.common.constants.py: https://review.openstack.org/#/c/168709/

Closes-Bug: #1441043

Change-Id: Iecfb15c541ed5d3cce95ba48f072af7fa60ac6f1
15 files changed:
neutron/agent/common/ovs_lib.py
neutron/common/constants.py
neutron/common/utils.py
neutron/db/migration/migrate_to_ml2.py
neutron/plugins/brocade/vlanbm.py
neutron/plugins/cisco/db/n1kv_db_v2.py
neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py
neutron/plugins/common/constants.py
neutron/plugins/common/utils.py
neutron/plugins/linuxbridge/agent/linuxbridge_neutron_agent.py
neutron/plugins/ml2/drivers/type_vlan.py
neutron/plugins/ml2/drivers/type_vxlan.py
neutron/plugins/openvswitch/agent/ovs_neutron_agent.py
neutron/tests/unit/common/test_utils.py
neutron/tests/unit/plugins/linuxbridge/agent/test_linuxbridge_neutron_agent.py