]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
VPNaaS REST Client UT Broken
authorPaul Michali <pcm@cisco.com>
Mon, 30 Jun 2014 22:31:42 +0000 (18:31 -0400)
committerPaul Michali <pcm@cisco.com>
Sun, 6 Jul 2014 13:57:08 +0000 (09:57 -0400)
commit7f0a8f09ab7867100081a898347a5f901e5a442b
tree307d1efbb47aa29651c5822259655655c85fd979
parent6e877945c923857395de3b5fd15953c58a4d74a4
VPNaaS REST Client UT Broken

When the H302 work was done, it broke two modules used for UT of
Cisco CSR VPNaaS REST client. Since the UT is currently disabled
(because the httmock library was not approved for test-requirements),
the error was not detected.

This fixes the files, so that they can still be used manually (by
locally importing httmock or its source file, and renaming the
module to remove the "_" prefix).

In the long term, the UT needs to be reworked to use httpretty,
which uses a register based mechanism, instead of a context
manager based mechanism, so this will take some effort. In addition.
there is discussion of switching to a new mock-request package,
instead of httpretty.

Change-Id: I8badc249ad021fdbdb2367b5416c72435ed58994
Closes-Bug: 1335977
Closes-Bug: 1326785
neutron/tests/unit/services/vpn/device_drivers/_test_cisco_csr_rest.py [moved from neutron/tests/unit/services/vpn/device_drivers/notest_cisco_csr_rest.py with 83% similarity]
neutron/tests/unit/services/vpn/device_drivers/cisco_csr_mock.py