]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Cisco VPN device driver post-merge cleanup
authorPaul Michali <pcm@cisco.com>
Wed, 12 Mar 2014 14:04:30 +0000 (14:04 +0000)
committerPaul Michali <pcm@cisco.com>
Wed, 19 Mar 2014 12:06:00 +0000 (12:06 +0000)
commit7f096512bbccee92da24e8f408f1d7f4f100cc95
tree29f8340684091d618f08b692f92e742127d394fa
parent30342f608e7b66142dfca53d69d1ef49e554969e
Cisco VPN device driver post-merge cleanup

During review for I-3 there were some minor comments regarding log
level on message and asserts for mock calls.

In addition, some debug logging enhancements were made between the
service and device driver to better indicate the source of the
shared "vpnservice_updated" RPC.

Lastly, unit tests were updated, based on a newer Cisco CSR image,
which had REST API fixes and behavior changes.

Change-Id: I22277462270df0b2cd642ec576e8652c9df146b5
Closes-bug: 1288387
neutron/services/vpn/device_drivers/cisco_csr_rest_client.py
neutron/services/vpn/device_drivers/cisco_ipsec.py
neutron/services/vpn/service_drivers/__init__.py
neutron/services/vpn/service_drivers/cisco_ipsec.py
neutron/tests/unit/services/vpn/device_drivers/cisco_csr_mock.py
neutron/tests/unit/services/vpn/device_drivers/notest_cisco_csr_rest.py
neutron/tests/unit/services/vpn/device_drivers/test_cisco_ipsec.py
neutron/tests/unit/services/vpn/service_drivers/test_cisco_ipsec.py