]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commit
spec: updates for rspec-puppet 2.x and rspec 3.x
authorSebastien Badia <sebastien.badia@enovance.com>
Sun, 22 Feb 2015 21:02:45 +0000 (22:02 +0100)
committerSebastien Badia <sbadia@redhat.com>
Wed, 13 May 2015 15:07:38 +0000 (17:07 +0200)
commit7dafee76397aee9c761927dae6e2bb8cabd3cd24
tree79bd05306c9a8fa5d284622b57c2773e9367da15
parent64d8cfb8c1637871bba8c692d0c8184b75aceba2
spec: updates for rspec-puppet 2.x and rspec 3.x

This patch aim to update our specs test in order to work with the new
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
in order to be prepared for rspec 3.x move.

In details:

  * Use shared_examples "a Puppet::Error" for puppet::error tests
  * Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
  * Fix spec tests for rspec-puppet 2.0.0
  * Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
  * Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)

Conflicts:
Gemfile
spec/classes/ceilometer_db_postgresql_spec.rb
spec/classes/ceilometer_db_spec.rb

Change-Id: Ieaff6bc8bdd8548648ff5e76b212d4df382fa8a3
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
(cherry picked from commit 55b7aad8cf0c902cd1469da8547f24e856b06de4)
20 files changed:
Gemfile
spec/classes/ceilometer_agent_auth_spec.rb
spec/classes/ceilometer_agent_central_spec.rb
spec/classes/ceilometer_agent_compute_spec.rb
spec/classes/ceilometer_agent_notification_spec.rb
spec/classes/ceilometer_alarm_evaluator_spec.rb
spec/classes/ceilometer_alarm_notifier_spec.rb
spec/classes/ceilometer_api_spec.rb
spec/classes/ceilometer_client_spec.rb
spec/classes/ceilometer_collector_spec.rb
spec/classes/ceilometer_config_spec.rb
spec/classes/ceilometer_db_mysql_spec.rb
spec/classes/ceilometer_db_spec.rb
spec/classes/ceilometer_expirer_spec.rb
spec/classes/ceilometer_init_spec.rb
spec/classes/ceilometer_keystone_auth_spec.rb
spec/classes/ceilometer_logging_spec.rb
spec/classes/ceilometer_policy_spec.rb
spec/classes/ceilometer_wsgi_apache_spec.rb
spec/shared_examples.rb