]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix the bug of can't get the desired image info
authorzhangsong <zhangsong@cmss.chinamobile.com>
Fri, 13 Nov 2015 16:44:53 +0000 (00:44 +0800)
committerzhangsong <zhangsong@cmss.chinamobile.com>
Sat, 28 Nov 2015 09:33:03 +0000 (17:33 +0800)
commit7cf6d6457c74a63ec7df282c402fcd31a60a12af
tree6cb275480108c6055cea4ee6e34e04e978738dbe
parent0a7103a24295e677e26a4a72d69830c2d4c41c48
Fix the bug of can't get the desired image info

When we use 'qemu-img info' command to get image info, some kinds
of image may show an 'unavailable' disk size. For example:

$qemu-img info sheepdog:volume-1af1afa0-7820-4063-9b90-4fa6161a74a9
image: sheepdog:volume-1af1afa0-7820-4063-9b90-4fa6161a74a9
file format: raw
virtual size: 10G (10737418240 bytes)
disk size: unavailable

$qemu-img info -f rbd rbd:data/foo
image: rbd:data/foo
file format: rbd
virtual size: 10G (10737418240 bytes)
disk size: unavailable
cluster_size: 4194304

The current code didn't consider 'unavailable' size, and it will
raise a ValueError in this case. This patch fixed this bug by
adding the judgment of 'unavailable' size.

Change-Id: Ic5f3b80e172baaafc07432319f8aa24bf117b392
Closes-Bug: #1516083
cinder/openstack/common/imageutils.py