]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove ovs-vsctl call from OVSInterfaceDriver
authorCedric Brandily <zzelle@gmail.com>
Wed, 26 Nov 2014 00:31:22 +0000 (00:31 +0000)
committerCedric Brandily <zzelle@gmail.com>
Wed, 3 Dec 2014 15:48:55 +0000 (15:48 +0000)
commit7c3921585e404c31272c4d31ed326f7323c062d8
treeada90b4382642b78ec55535618771a59d5529280
parent670f578aca04937b6f6275240f457498995e81fa
Remove ovs-vsctl call from OVSInterfaceDriver

ovs_lib module is responsible for the interaction with OVS but
OVSInterfaceDriver._ovs_add_port() method calls directly
ovs-vsctl which implies inconsistencies: ovs_lib calls ovs-vsctl
with a timeout but not OVSInterfaceDriver._ovs_add_port().

This change moves ovs-vsctl call in OVSInterfaceDriver._ovs_add_port
to ovs_lib.

Closes-Bug: #1396489
Change-Id: I4d03f8beef2c5f2366ad2d1cf5f0b18b4f2857cd
neutron/agent/linux/interface.py
neutron/agent/linux/ovs_lib.py
neutron/tests/unit/agent/linux/test_ovs_lib.py
neutron/tests/unit/test_linux_interface.py