]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Reject trailing whitespaces in IP address
authorHironori Shiina <shiina.hironori@jp.fujitsu.com>
Wed, 26 Nov 2014 04:41:06 +0000 (13:41 +0900)
committerHironori Shiina <shiina.hironori@jp.fujitsu.com>
Wed, 26 Nov 2014 06:48:03 +0000 (15:48 +0900)
commit7af435ca40aa222c3f164a3750e8f11694fdcfc6
treeb1f27b1ba938c391bfaf8763edf6397526d5fb0f
parent963d699df5faa48857f43f1870b68b1a13b5e5f5
Reject trailing whitespaces in IP address

Trailing whitespaces in IP address or CIDR pass API validation. These
whitespaces sometimes cause serious troubles. For instance, a trailing
CR code in allocation pools cause an ovs-agent to crash when calling
iptables. In this case, a tenant user's operation mistake affects whole
system.

By modifying _validate_no_whitespace() to reject data with whitespaces
in the beginning and the end, the IP address and CIDR validation
detects invalid attributes. The MAC address validation already rejects
these whitespaces.

Change-Id: Id4589236cfd44c2fd5956c5ab4ab6871381a0c34
Closes-Bug: #1393329
neutron/api/v2/attributes.py
neutron/tests/unit/test_attributes.py