]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Refactor IpRuleCommand to take more arguments
authorCarl Baldwin <carl.baldwin@hp.com>
Tue, 30 Jun 2015 20:23:39 +0000 (20:23 +0000)
committerCarl Baldwin <carl.baldwin@hp.com>
Thu, 2 Jul 2015 23:04:00 +0000 (23:04 +0000)
commit7a73c2d0f87bb269d0cced1847edce4d1e76179e
tree142e6d83e1ffb57533def120f22bed533e306074
parente91459589bd21f363db27897756c743a3d10af90
Refactor IpRuleCommand to take more arguments

The iproute2 rule command takes more arguments than the ones supported
by this wrapper.  Particularly, for address scopes, we're interested
in iif and fwmark.  Instead of adding these piecemeal, this change
makes the wrapper flexible to pass any of them using kwargs.

Callers of add / delete are updated to pass keyword arguments for
table and priority since they are no longer required positional
arguments.  This looks better anyway.

Change-Id: Ia93b086b787c34bd560961cb84e4a003cf359e7e
Partially-Implements: blueprint address-scopes
neutron/agent/l3/dvr_local_router.py
neutron/agent/linux/ip_lib.py
neutron/tests/unit/agent/l3/test_dvr_local_router.py
neutron/tests/unit/agent/linux/test_ip_lib.py