]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Code Review / openstack-build / neutron-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 3b42338) | patch
extra_dhcp_opt add checks for empty strings
authordekehn <dekehn@gmail.com>
Tue, 3 Dec 2013 22:28:55 +0000 (15:28 -0700)
committerdekehn <dekehn@gmail.com>
Fri, 13 Dec 2013 15:40:28 +0000 (08:40 -0700)
commit794a1325dfc8a6937412a597f19acecf08d4b34a
tree27d2245b543312cc16e26182bb9915bb1c1e2f81tree | snapshot
parent3b4233873539bad62d202025529678a5b0add412commit | diff
extra_dhcp_opt add checks for empty strings

When passing extra-dhcp-opt into the port-create where an empty string
is provided as opt_value='   ', the create and update routine will load the
empty string into the DB. The result when written to the opts file is:
"tag:ece4c8aa-15c9-4f6b-8c42-7d4e285734bf,option:server-ip-address", which
when read by dnsmasq has been tested to cause dnsmasq to segment fault.

Change-Id: I31de4a3d27092bb219d20221c5ef5a6b22e050dc
Closes-Bug: #1257467
neutron/api/v2/attributes.py diff | blob | history
neutron/extensions/extra_dhcp_opt.py diff | blob | history
neutron/tests/unit/test_attributes.py diff | blob | history
neutron/tests/unit/test_extension_extradhcpopts.py diff | blob | history