]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Code Review / openstack-build / neutron-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: f131d65) | patch
Make linux.utils.execute log error on return codes
authorAaron Rosen <aaronorosen@gmail.com>
Tue, 27 May 2014 20:39:39 +0000 (13:39 -0700)
committerAaron Rosen <aaronorosen@gmail.com>
Thu, 29 May 2014 01:49:53 +0000 (18:49 -0700)
commit77046d0d889a8bff095083ae80a2accd0e25406b
tree2d7dee1c4e8c243077f7fd0c57e024e8f3e5240ftree | snapshot
parentf131d65d92a0ff4690deaf64a5bbd16da8af4bb9commit | diff
Make linux.utils.execute log error on return codes

Previously, the execute method in neutron logs everything as debug which hides
a lot of extremely fatal errors like unable to apply security group rules!
This patch changes this code so that we log all non 0 returns as error.

Change-Id: I7328e62269212ccd9c7950ff064a3e337de56918
Closes-bug: 1323832
Related-bug: 1322945
neutron/agent/linux/utils.py diff | blob | history
neutron/tests/unit/test_agent_linux_utils.py diff | blob | history