]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Security Group rule validation for ICMP rules
authorsridhargaddam <sridhar.gaddam@enovance.com>
Thu, 3 Apr 2014 13:00:07 +0000 (18:30 +0530)
committersridhargaddam <sridhar.gaddam@enovance.com>
Mon, 14 Apr 2014 15:30:23 +0000 (21:00 +0530)
commit7607e3da884551e5c4cfe49de390afbddbb2a9b3
tree3cc312eeeaa4b71ab4a884948240e44fb5578a32
parent4cfb85f2c86580d5016c974f1596f85d5f45d494
Security Group rule validation for ICMP rules

Currently there is no validation in Security Group rules
when an ICMP rule is added with icmp code alone. A rule
is getting added but there is a mismatch between SG rules
and the corresponding iptables rule that is added.
This patch does the necessary validation on the input.

Closes-Bug: #1301838
Change-Id: I510abac4c426f68ea57c99a5fef3da4058f88797
neutron/db/securitygroups_db.py
neutron/extensions/securitygroup.py
neutron/tests/unit/test_extension_security_group.py