]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Make sure floating IPs + gateways must be on external nets
authorDan Wendlandt <dan@nicira.com>
Thu, 6 Sep 2012 05:43:22 +0000 (22:43 -0700)
committerDan Wendlandt <dan@nicira.com>
Thu, 6 Sep 2012 05:43:22 +0000 (22:43 -0700)
commit75e2dfffaf02dd8f1b85b510e58d2f3719d97f19
tree1e284e811627c792cac28eeb19c9680eb1943005
parent0f4b24a2bf1dddaa892e6b749a6a305e53446757
Make sure floating IPs  + gateways must be on external nets

bug #1042030

- adds admin-writable, world-readable router:external attribute to
the network object if L3 extension is loaded.
- prevents floating ips from being created unless network is external
- shortens L3 extensions alias from 'os-quantum-router' to 'router' to
make attribute extensions more readable.

WIP:
- Need to add policy logic so non-admin users can always see external
networks without requiring that these networks are shared (since VMs can
always create ports on shared networks, but provider may want to have
externals networks that VMs cannot directly plug into.

Random clean-up:
- prevent delete_network in plugins from implying it returns something
- modify extensions.py so that exceptions during calls to
get_extended_resources() will actually be logged if unexpected.
- unset executable bit on test_iptables_manager.py to make sure tox
actually runs it.

Change-Id: I5bbf063927b93458da7cb467d9ad5c92ebabbbf7
etc/policy.json
quantum/db/l3_db.py
quantum/extensions/extensions.py
quantum/extensions/l3.py
quantum/plugins/linuxbridge/lb_quantum_plugin.py
quantum/plugins/openvswitch/ovs_quantum_plugin.py
quantum/tests/unit/test_db_plugin.py
quantum/tests/unit/test_iptables_manager.py [changed mode: 0755->0644]
quantum/tests/unit/test_l3_plugin.py