]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Avoid testing code duplication which introduced testing bugs
authorMiguel Angel Ajo <mangelajo@redhat.com>
Fri, 5 Sep 2014 12:10:35 +0000 (14:10 +0200)
committerMiguel Angel Ajo <mangelajo@redhat.com>
Fri, 5 Sep 2014 14:38:17 +0000 (16:38 +0200)
commit74a292ceba0be6aaa7ea1911cac2f102eb3db90e
tree1951b879feadfb47a806c7b4bf24054ed1d7d533
parent3b46f2ca28fedc3de6769a0a5dd48b19ab900ce0
Avoid testing code duplication which introduced testing bugs

SecurityGroupAgentEnhancedRpcTestCase duplicated code in
SecurityGroupAgentRpcTestCase setUp, also
TestSecurityGroupAgentEnhancedRpcWithIptables duplicated
code from TestSecurityGroupAgentWithIptables setUp()
introducing bugs by improper initialization, like a missing
    self.iptables.use_ipv6 = True
which in combination with tests.unit.test_ipv6.TestIsEnabled
produced inconsistent testing results.

Change-Id: Ic0b596b6fe1d8273df197e9426abad818832c00a
Closes-bug: #1365829
neutron/tests/unit/test_security_groups_rpc.py