]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Rename self.tgtadm to self.target_helper
authorEric Harney <eharney@redhat.com>
Wed, 29 Jan 2014 15:45:03 +0000 (10:45 -0500)
committerEric Harney <eharney@redhat.com>
Thu, 6 Feb 2014 20:55:22 +0000 (15:55 -0500)
commit74762d17b92d6de563a310232fe00c1587776f7e
tree3f5ab8d386f2f571dc94e3e62d34230c4dd0e491
parentf4b336b4176c771950486532803808ce451a0d64
Rename self.tgtadm to self.target_helper

Using "tgtadm" for this member variable is confusing because it
actually represents tgt, IET, and LIO.  Rename to a more generic
term to make things more readable.

Also remove "tgtadm" from method names and references in tests
where it is not tgtadm-specific.

I'm choosing the name "target_helper" because "tgtadm" = tgtd,
and "iscsi_helper" doesn't fit when using RDMA in ISERDriver.

Change-Id: I73fab03eb6635be6b49950e3a0ccc0e9801697ca
cinder/tests/test_iscsi.py
cinder/volume/driver.py
cinder/volume/drivers/block_device.py
cinder/volume/drivers/lvm.py