]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
Fix extra quotes in firewall string matching
authorIBBoard <github@ibboard.co.uk>
Wed, 23 Sep 2020 19:58:09 +0000 (20:58 +0100)
committerGitHub <noreply@github.com>
Wed, 23 Sep 2020 19:58:09 +0000 (20:58 +0100)
commit739f1e66b7b3efe91edf96df4b4866f677cfef39
tree56d9cdf3f8f79e905cb0670c4609eb40f89c04cc
parenta90b56560d0fb4ec5b9a9e0fbef86aa3e1cb1c5d
Fix extra quotes in firewall string matching

As reported by Steve Traylon[1] and @patricknelson[2], the munging adds extra quotes to the string.
This breaks the string matching in iptables, as it looks for literal single quotes in the match.

Removing the munging fixes this.

[1] https://tickets.puppetlabs.com/browse/MODULES-3454?focusedCommentId=686988&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-686988
[2] https://github.com/puppetlabs/puppetlabs-firewall/commit/3655c6bd33d662a3813c2f66cd0bc5889c68c2c2#diff-379160b60a9bdf297b92a51d20efd8c3R1426
lib/puppet/type/firewall.rb