]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Make L3RpcCallback a separate callback class
authorAkihiro Motoki <motoki@da.jp.nec.com>
Mon, 18 Aug 2014 18:49:30 +0000 (03:49 +0900)
committerAkihiro Motoki <motoki@da.jp.nec.com>
Wed, 27 Aug 2014 00:54:25 +0000 (09:54 +0900)
commit73719a80bf4ea036a52617bffdf6d5bb725e4a90
treeee2349a6babeec2e54bdb40a0fc28fdfb0cb66aa
parent3f16a695442d3e7eef152285c030e02c50ff63ec
Make L3RpcCallback a separate callback class

RPC has a version of itself. In Neutron a plugin implements
several RPC interface, so a single RPC version doesn't work.
In Mixin callback class approach, RPC versioning depends on
each plugin implementation and it makes harder to maintain
RPC version appropriately. This patch series replaces mixin
RPC callback of server side with a separate class.

This commit handles server-side callback of L3-agent RPC interface.
L3-agent server-side callback class is moved from db/ to
api/rpc/handlers because it doesn't involve any db operations
and defining all RPC interfaces in a single place sounds reasonable.

Note that moving other L3-agent related RPC interface class
to api/rpc/handlers will be done in a separate patch as this patch
focuses on reorganizing the server-side RPC callback class.

Partial-Bug: #1359416
Change-Id: Ie3f2c9b2ad907a1110e05fe94d42e41e93fbcaa7
17 files changed:
neutron/api/rpc/handlers/l3_rpc.py [moved from neutron/db/l3_rpc_base.py with 96% similarity]
neutron/plugins/brocade/NeutronPlugin.py
neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py
neutron/plugins/hyperv/hyperv_neutron_plugin.py
neutron/plugins/hyperv/rpc_callbacks.py
neutron/plugins/linuxbridge/lb_neutron_plugin.py
neutron/plugins/mlnx/mlnx_plugin.py
neutron/plugins/mlnx/rpc_callbacks.py
neutron/plugins/nec/nec_plugin.py
neutron/plugins/oneconvergence/plugin.py
neutron/plugins/openvswitch/ovs_neutron_plugin.py
neutron/plugins/ryu/ryu_neutron_plugin.py
neutron/services/l3_router/l3_arista.py
neutron/services/l3_router/l3_router_plugin.py
neutron/tests/unit/nec/test_agent_scheduler.py
neutron/tests/unit/openvswitch/test_agent_scheduler.py
neutron/tests/unit/test_l3_plugin.py