]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove unused variables from ensure_export()
authorMitsuhiro Tanino <mitsuhiro.tanino@hds.com>
Sat, 10 Jan 2015 01:11:43 +0000 (20:11 -0500)
committerMitsuhiro Tanino <mitsuhiro.tanino@hds.com>
Sat, 10 Jan 2015 01:11:43 +0000 (20:11 -0500)
commit73363c1cacac15e8caee0df44db4a7dfdea9cc35
treefdc26c8bc632cd64b0feba8694fea882589ba80f
parentc705d398f696cbaee7dc03e8b37279257b8f941c
Remove unused variables from ensure_export()

After introducing commit 9651f547147188645942466602c92cce06666483,
these three variables are obsolete in ensure_export().
By remaining these variable, ensure_export() fails to export
volumes after c-vol service is restart because the caller of
ensure_export() in lvm driver does not pass these variables.

- iscsi_name, volume_group, config

Main clean up is done by commit Ibfd1feefd72c43ef316b267e9d6645f2e67e2558.
This patch adds some tests for tgt, lio, and iser targets.
And also adds initialization of chap_auth_userid and chap_auth_password
in create_iscsi_target() because these variables might be referred
before definition.

Closes-bug: 1408121
Related-bug: 1408171
Change-Id: I8766eee33ae07fea71873809bfec37b8352c3a89
cinder/tests/targets/test_base_iscsi_driver.py
cinder/tests/targets/test_iser_driver.py [new file with mode: 0644]
cinder/tests/targets/test_lio_driver.py [new file with mode: 0644]
cinder/tests/targets/test_tgt_driver.py
cinder/volume/targets/lio.py