]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Improve agent-based flat/vlan ml2 port binding failure logging
authorAssaf Muller <amuller@redhat.com>
Tue, 30 Sep 2014 16:31:57 +0000 (19:31 +0300)
committerAssaf Muller <amuller@redhat.com>
Wed, 21 Jan 2015 13:13:49 +0000 (08:13 -0500)
commit72e285ac1aad2f5a4b246435cf4d4b0126fb3431
treeaec7c33bf2f338e6f51c2c78eb50767bc3fcbb8d
parentdbd37747d02e0f4592df37c68f044246af27f859
Improve agent-based flat/vlan ml2 port binding failure logging

Port binding failure is an error and should be reported as such.
Additionally, if a port binding fails on a host due to missing
bridge mappings, it's currently quite a mystery to find out. This
should be logged instead of requiring users to debug code. Not
everyone enjoys debugging Python, as weird as that is!

I refactored out the common code in check_segment_for_agent
in order to make logging more robust for all agent-based mechanism
drivers. The OVS and LB mech drivers already log due to a bridge
mappings mismatch and the other agent based mech drivers
will now log as well.

Closes-Bug: #1377710
Change-Id: I451a0763908adcd845721e8cda7f3189da6c8b81
12 files changed:
neutron/plugins/ml2/drivers/mech_agent.py
neutron/plugins/ml2/drivers/mech_hyperv.py
neutron/plugins/ml2/drivers/mech_linuxbridge.py
neutron/plugins/ml2/drivers/mech_ofagent.py
neutron/plugins/ml2/drivers/mech_openvswitch.py
neutron/plugins/ml2/drivers/mlnx/mech_mlnx.py
neutron/plugins/ml2/managers.py
neutron/tests/unit/ml2/drivers/test_mech_mlnx.py
neutron/tests/unit/ml2/drivers/test_ofagent_mech.py
neutron/tests/unit/ml2/test_mech_hyperv.py
neutron/tests/unit/ml2/test_mech_linuxbridge.py
neutron/tests/unit/ml2/test_mech_openvswitch.py