]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove usage of locals() for formatting from cinder.tests.*
authorHaomai Wang <haomai@unitedstack.com>
Mon, 24 Jun 2013 06:03:31 +0000 (14:03 +0800)
committerHaomai Wang <haomai@unitedstack.com>
Mon, 24 Jun 2013 06:03:31 +0000 (14:03 +0800)
commit729a08a019837bf4a5cbce5eee46a0a6e8e12acd
tree2c2fa52afb87ad41ce02d781b51cd6e60c50adfd
parent6e90e4089f58ac9b1e28e5199f0dea15f3ae4e6e
Remove usage of locals() for formatting from cinder.tests.*

Using of locals() for formatting string is a nasty thing because:
1) It is not so clear as using explicit dicts
2) It could produce hidden errors during refactoring
3) Changing name of variable causes change in message
4) Creating a lot of unused variables

Fix bug 1171936

Change-Id: I67aa5bff650b55484ca76adf5be8555f72a4c426
cinder/tests/fake_utils.py
cinder/tests/integrated/api/client.py
cinder/tests/test_migrations.py