]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
(#11093) Improve log_level property so it converts names to numbers
authorJonathan Boyett <jonathan@failingservers.com>
Thu, 1 Dec 2011 02:52:35 +0000 (18:52 -0800)
committerKen Barber <ken@bob.sh>
Thu, 1 Dec 2011 11:15:41 +0000 (11:15 +0000)
commit6e7923870a932fa038f6c3a430f000ba3bfa95ca
treec60ed04ea4eb354b4b8e0b316f7e948ca40bd397
parent9e01dafa5d935dc4e8c98973c37011f31f0a8760
(#11093) Improve log_level property so it converts names to numbers

Previously the log_level property was constantly reloading due to the fact
that iptables was converting names to numbers. So unless you were using
numbers in your log_level setting, it was constantly telling you it needed
to be changed.

Now we convert the names to numbers in the munge so when comparing it will
always hopefully match.

Also, the default value when the jump value is 'LOG' is now set to 4 (warn)
based on iptables own defaults.
examples/iptables/test.pp
lib/puppet/provider/firewall/iptables.rb
lib/puppet/type/firewall.rb
lib/puppet/util/firewall.rb
spec/fixtures/iptables/conversion_hash.rb
spec/unit/puppet/type/firewall_spec.rb