]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Propoerly call oslo's Service stop and wait
authorGorka Eguileor <geguileo@redhat.com>
Tue, 16 Feb 2016 18:20:46 +0000 (19:20 +0100)
committerGorka Eguileor <geguileo@redhat.com>
Tue, 16 Feb 2016 18:20:46 +0000 (19:20 +0100)
commit6daa6ad3f528330d97b85c3eebfc494fc07a2f95
tree218465371bb401fd33285f89b4a07bd3f9eb2f99
parent010df28d76a2ec02d348da45db2f822b21bedc79
Propoerly call oslo's Service stop and wait

We are not calling oslo_service.Service's stop method with the graceful
parameter which ensure that stop waits for threads to properly stop
instead of just forcefully stopping them.  This is not an issue for
Cinder at this moment because the rpcserver.stop call waits for
everything to gracefully stop, but we may have something there running
and we wouldn't want to kill it.

We should also call oslo_service.Service.wait method from our
Service.wait method.

This patch ensures that we are properly calling oslo_Service.Service's
methods.

Change-Id: I8764571c41509fdf1ff7950e9d8d7d6cf0d2f57d
cinder/service.py