]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Clean up attach/detach tests.
authorAvishay Traeger <avishay@il.ibm.com>
Mon, 8 Apr 2013 09:19:32 +0000 (12:19 +0300)
committerAvishay Traeger <avishay@il.ibm.com>
Mon, 8 Apr 2013 09:25:27 +0000 (12:25 +0300)
commit6d7a681fa38bc39e6c0d0db684caec627b4daffa
tree5ab65cd17fe36566e018ce186d686fd2e2d4f51f
parent0992004ab2c85b07b1eec5f62ac665513286b915
Clean up attach/detach tests.

The code tested by test_preattach_status_volume was moved, and the
test no longer tested anything relevant (i.e., instead of checking
that the volume is 'attached', the test was changed to test for
'available' since the attach code was moved). This patch, therefore,
deletes that test.

Further, test_run_attach_detach_volume called database functions for
attaching and detaching. This patch changes those calls to call
higher-level functions which in turn call the database functions. This
gives better code coverage and gives the tests more meaning.

Change-Id: If688fe6a14940148b5792256c8507803e8cde901
cinder/tests/test_volume.py