]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Change all occurences of no_delete to do_delete
authorAssaf Muller <amuller@redhat.com>
Sun, 4 May 2014 15:26:43 +0000 (18:26 +0300)
committerAssaf Muller <amuller@redhat.com>
Sun, 13 Jul 2014 11:09:26 +0000 (14:09 +0300)
commit69dfbd9468282f9ce16cc5b0cb1bcb121632a0d8
treeb02f5b7a7193ace208c4e17d7e24c80b9f13bd99
parent59da928e945ec58836d34fd561d30a8a446e2728
Change all occurences of no_delete to do_delete

Previously, ports, networks and subnets had a do_delete=True
parameter. By default, these resources were deleted at the
end of the context manager scope. All other resources used
a different semantic: no_delete=False.

This caused confusing situations such as:
with self.subnet(network, do_delete=False) as subnet:
    with self.security_group(no_delete=True) as sg:
        pass

Now all resources use the same do_delete semantic.

Closes-Bug: #1336196
Change-Id: I4627481813f714819efe85831e2a55975ea71ed4
28 files changed:
neutron/tests/unit/bigswitch/test_restproxy_plugin.py
neutron/tests/unit/bigswitch/test_router_db.py
neutron/tests/unit/db/firewall/test_db_firewall.py
neutron/tests/unit/db/loadbalancer/test_db_loadbalancer.py
neutron/tests/unit/db/metering/test_db_metering.py
neutron/tests/unit/db/vpn/test_db_vpnaas.py
neutron/tests/unit/ml2/test_ml2_plugin.py
neutron/tests/unit/nec/test_nec_plugin.py
neutron/tests/unit/nec/test_packet_filter.py
neutron/tests/unit/nuage/test_nuage_plugin.py
neutron/tests/unit/openvswitch/test_agent_scheduler.py
neutron/tests/unit/services/firewall/test_fwaas_plugin.py
neutron/tests/unit/services/loadbalancer/drivers/embrane/test_plugin_driver.py
neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py
neutron/tests/unit/services/loadbalancer/drivers/test_agent_driver_base.py
neutron/tests/unit/services/loadbalancer/test_agent_scheduler.py
neutron/tests/unit/services/metering/test_metering_plugin.py
neutron/tests/unit/test_db_plugin.py
neutron/tests/unit/test_extension_extraroute.py
neutron/tests/unit/test_extension_security_group.py
neutron/tests/unit/test_l3_plugin.py
neutron/tests/unit/vmware/extensions/test_qosqueues.py
neutron/tests/unit/vmware/test_nsx_plugin.py
neutron/tests/unit/vmware/vshield/test_firewall_driver.py
neutron/tests/unit/vmware/vshield/test_fwaas_plugin.py
neutron/tests/unit/vmware/vshield/test_lbaas_plugin.py
neutron/tests/unit/vmware/vshield/test_loadbalancer_driver.py
neutron/tests/unit/vmware/vshield/test_vpnaas_plugin.py