]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
LVM migrate: Use keywords for the brick instance
authorFlavio Percoco <flaper87@gmail.com>
Thu, 5 Dec 2013 12:48:24 +0000 (13:48 +0100)
committerFlavio Percoco <flaper87@gmail.com>
Thu, 5 Dec 2013 22:26:08 +0000 (23:26 +0100)
commit69ce114232f9102220b45c8242eda3e78872a3e6
treecf2471e4893fd25a1bea7473b4200c288af1cee3
parente99cd785d8ddbffcd1d741cf336b2e929c6cb28f
LVM migrate: Use keywords for the brick instance

In the `migrate_volume` method a new instance is created when the
dest_vg is not equal to the source vg. This new brick instance is
created using positional arguments instead of keywords. However, some of
those arguments are passed in the wrong positions.

This patch uses keywords for the misplaced arguments.

The patch also changes `test_lvm_migrate_volume_proceed` in order to
fully test the happy path and catch things like this.

Closes-bug: #1258128
Change-Id: I75cf91171709554053fd5b52a4aae4e176e8364e
cinder/tests/test_volume.py
cinder/volume/drivers/lvm.py