]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
SQL scripts should not manage transactions
authorIhar Hrachyshka <ihrachys@redhat.com>
Fri, 12 Sep 2014 08:57:34 +0000 (10:57 +0200)
committerIhar Hrachyshka <ihrachys@redhat.com>
Fri, 12 Sep 2014 08:57:34 +0000 (10:57 +0200)
commit675e0e5889cce269a758abf5fc6933dd09b0f9fd
tree458ee9cce56395d9b907c5484b04fae8869f9aba
parent69b4cfd09c61da1ccd9c9587dcd043240bc3e9d0
SQL scripts should not manage transactions

Cinder SQL scripts assume too much about the environment and the way in
which they are executed by sqlalchemy-migrate. Particularly, they manage
transactions on their own even though sqlalchemy-migrate do it itself,
plus it assumes that scripts are executed in one go (even though
standard Python DB-API 2.0 does not mention multi-statement SQL commands
to be executed on DB cursors.

blueprint enable-mysql-connector

Change-Id: I10c58b3af75d3ab9153a8bbd2a539bf1577de328
Closes-Bug: 1368391
cinder/db/sqlalchemy/migrate_repo/versions/005_sqlite_downgrade.sql
cinder/db/sqlalchemy/migrate_repo/versions/007_sqlite_downgrade.sql
cinder/db/sqlalchemy/migrate_repo/versions/011_sqlite_downgrade.sql
cinder/db/sqlalchemy/migrate_repo/versions/012_sqlite_downgrade.sql
cinder/db/sqlalchemy/migrate_repo/versions/013_sqlite_downgrade.sql
cinder/db/sqlalchemy/migrate_repo/versions/014_sqlite_downgrade.sql