]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Reorder operations in create_vip
authorEugene Nikanorov <enikanorov@mirantis.com>
Wed, 13 Aug 2014 11:10:45 +0000 (15:10 +0400)
committerEugene Nikanorov <enikanorov@mirantis.com>
Tue, 19 Aug 2014 01:32:44 +0000 (05:32 +0400)
commit65de01dcb1c49271ad1e5067d8dfd206788086d4
tree533fd85f32497e48f62985208338f5513b2ba463
parente2c72495f4cacbafb650fb1e429ea68ba8c07836
Reorder operations in create_vip

Previously VIP's port creation was moved outside the transaction
to avoid deadlocks related to rpc calls.
It led to small chance of VIP being fetched by rpc code with
port being still None.

This patch reorders VIP association with the pool so it's done
only after port has been created.

This patch also leaves small possibility of uncaught exception in
case of pool being concurrently deleted in the process of VIP creation

Change-Id: I584558aecc92db4d19fb72b1d006868b840a4d8c
Closes-Bug: #1356227
neutron/db/loadbalancer/loadbalancer_db.py