]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Validate CIDR given as ip-prefix in security-group-rule-create
authormarios <marios@redhat.com>
Fri, 29 Nov 2013 16:23:54 +0000 (18:23 +0200)
committermarios <marios@redhat.com>
Wed, 16 Apr 2014 16:15:29 +0000 (18:15 +0200)
commit65aa92b0348b7ab8413f359b00825610cdf66607
tree3243f2d3a71bf86aeaa00e5b48aec87427cf95ee
parentf89d3fec9b34459683491de28ab5daccd9c12093
Validate CIDR given as ip-prefix in security-group-rule-create

There was no validation for the provided ip prefix. This just adds
a simple parse using netaddr and explodes with appropriate message.
Also makes sure ip prefix _is_ cidr (192.168.1.1-->192.168.1.1/32).

Validation occurs at the attribute level (API model) as well as at
the db level, where the ethertype is validated against the ip_prefix
address type.

Unit test cases added - bad prefix, unmasked prefix and incorrect
ethertype. Also adds attribute test cases for the added
convert_ip_prefix_to_cidr method

Change-Id: I71fb8c887963a122a5bd8cfdda800026c1cd3954
Closes-Bug: 1255338
neutron/common/exceptions.py
neutron/db/securitygroups_db.py
neutron/extensions/securitygroup.py
neutron/tests/unit/test_extension_security_group.py
neutron/tests/unit/test_security_groups_rpc.py