]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Hacking Checks for assertTrue/IsNone()
authorKendall Nelson <kjnelson@us.ibm.com>
Tue, 17 Nov 2015 18:39:58 +0000 (12:39 -0600)
committerKendall Nelson <kjnelson@us.ibm.com>
Wed, 25 Nov 2015 17:22:35 +0000 (11:22 -0600)
commit635440c90c8c0a6fcb07e7cac574c4888dd8ce21
tree28ae62a6305281ddfcd7634c0605e8cc30bbf0b8
parent22331767727117464f9b5eddc348b7547684e616
Hacking Checks for assertTrue/IsNone()

This patch adds a hacking check to make sure that assertEquals isn't
comparing the result value to True or None. When developers
use assertEquals(None, return_value) the check will catch it when
pep8 runs and suggest using assertIsNone(return_value) instead.
Similar situations will occur when trying to use assertTrue(True,
return_value).

This patch also makes the necessary changes that get caught by the
new hacking check.

Change-Id: I56cc8121784eee617c09fb4e92b4ebb5877a0553
38 files changed:
HACKING.rst
cinder/hacking/checks.py
cinder/tests/unit/api/contrib/test_admin_actions.py
cinder/tests/unit/api/contrib/test_backups.py
cinder/tests/unit/api/v1/test_volumes.py
cinder/tests/unit/api/v2/test_volumes.py
cinder/tests/unit/brick/test_brick_lvm.py
cinder/tests/unit/image/test_glance.py
cinder/tests/unit/scheduler/test_host_manager.py
cinder/tests/unit/targets/test_base_iscsi_driver.py
cinder/tests/unit/targets/test_tgt_driver.py
cinder/tests/unit/test_api_urlmap.py
cinder/tests/unit/test_backup.py
cinder/tests/unit/test_cloudbyte.py
cinder/tests/unit/test_context.py
cinder/tests/unit/test_dellscapi.py
cinder/tests/unit/test_dothill.py
cinder/tests/unit/test_emc_vmax.py
cinder/tests/unit/test_gpfs.py
cinder/tests/unit/test_hacking.py
cinder/tests/unit/test_hitachi_hnas_nfs.py
cinder/tests/unit/test_hp_xp_fc.py
cinder/tests/unit/test_hpe3par.py
cinder/tests/unit/test_ibm_flashsystem.py
cinder/tests/unit/test_ibm_flashsystem_iscsi.py
cinder/tests/unit/test_ibmnas.py
cinder/tests/unit/test_infortrend_common.py
cinder/tests/unit/test_netapp_eseries_iscsi.py
cinder/tests/unit/test_storwize_svc.py
cinder/tests/unit/test_v6000_common.py
cinder/tests/unit/test_v7000_fcp.py
cinder/tests/unit/test_vmware_vmdk.py
cinder/tests/unit/test_volume_utils.py
cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_7mode.py
cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py
cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_7mode.py
cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_base.py
cinder/tests/unit/volume/drivers/netapp/test_utils.py