]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Factor out LVM code.
authorAvishay Traeger <avishay@il.ibm.com>
Wed, 9 Jan 2013 07:31:19 +0000 (09:31 +0200)
committerAvishay Traeger <avishay@il.ibm.com>
Sun, 13 Jan 2013 06:28:19 +0000 (08:28 +0200)
commit5f41390dde7305e8374fe9bd193c396e6ea04350
tree151d9bf83c83138804cf7c380b3ab4e961d7dcc9
parent643f9169c4aae46f8c2ce0b8ad725c55946a4afd
Factor out LVM code.

Currently volume drivers inherit from VolumeDriver and ISCSIDriver,
which contain LVM-specific code. The LVM-specific functions are
generally overridden. The problem is that there is no place for
generic code for all drivers to inherit, which the LVM driver can
override. This patch basically makes the VolumeDriver and ISCSIDriver
classes mostly empty and moves the LVM-specific code to lvm.py. Also,
moved the global _iscsi_location() and _iscsi_authentication()
functions into the new LVMISCSIDriver class since nobody else used
them.

Change-Id: I067c975de97913bdc39086ad203cddef0c393c7a
Implements: blueprint factor-out-lvm-code
cinder/tests/fake_driver.py
cinder/tests/fake_flags.py
cinder/tests/test_volume.py
cinder/volume/driver.py
cinder/volume/drivers/lvm.py [new file with mode: 0644]
cinder/volume/manager.py
etc/cinder/cinder.conf.sample