]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix type change in bootable setting of volume view
authorJohn Griffith <john.griffith@solidfire.com>
Thu, 19 Sep 2013 19:05:05 +0000 (13:05 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Thu, 19 Sep 2013 19:05:05 +0000 (13:05 -0600)
commit5d499395ac8028f4863e9a892453a197b254d384
treebcd735d5c8c8122dd0f88d7808ca8dca0d6023c7
parent6dda3358746289d6e1475779683af22592c217ae
Fix type change in bootable setting of volume view

Change Idd47a0a8069ee905b81c7aae562b82767ad91930 fixed a db
query issue, by removing the image_metadata querie in the get/show
methods.

The problem however is that we just passed the setting from the volume
object directly in the summary view builder.  This results in changing
the type of the value from a string "true/false" to a bool True/False
which is no good.

This patch converts the object member back to a string like it used to
be so we don't break any compat or expectations in API behavior.

Fixes bug #1227837

Change-Id: I55c0e25134ae429802ddf313d6d26f1fad19ca94
cinder/api/v1/volumes.py
cinder/tests/api/v1/test_volumes.py