]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Dell FC driver inheritance order causing failures
authorSean McGinnis <sean_mcginnis@dell.com>
Tue, 10 Mar 2015 16:20:25 +0000 (11:20 -0500)
committerSean McGinnis <sean_mcginnis@dell.com>
Tue, 10 Mar 2015 16:20:25 +0000 (11:20 -0500)
commit5b7c123056b9f6b91b3a4cff776916e1ebdbfd99
tree58d2b02a5cf37010fc1c11c1cda067e5d8c7bf9b
parentb7452ac30bc803a864600a868afd1ab647f59263
Dell FC driver inheritance order causing failures

After commit 610c672998c87e2bf2f919a4fdea86749c748a1f merged
the third party CI test runs for the Dell Storage Center fibre
channel driver started failing. This appeared to be a change
in get_volume_stats calls.

After isolating the cause of this problem it was identified
that the order of the inherited classes for the driver was
resulting in the wrong overridden get_volume_stats call to be
called.

This patch fixes this be just switching the order of the two
parent classes DellCommonDriver and FibreChannelDriver. Swapping
these two results in the correctly overridden call to be made
and CI tests to pass successfully.

Change-Id: I58ec1fde585179037aeca8d449e74d0333fb013d
Closes-Bug: 1430421
cinder/volume/drivers/dell/dell_storagecenter_fc.py