]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Send DHCP notifications regardless of agent status
authorMaru Newby <marun@redhat.com>
Tue, 10 Dec 2013 16:10:42 +0000 (16:10 +0000)
committerMaru Newby <marun@redhat.com>
Thu, 19 Dec 2013 07:08:19 +0000 (07:08 +0000)
commit5a8e67be491a2b4897c01aeccd584381f74bc294
treef15dbd5ce0a0e255354a5bd556c436538340a4fd
parenta7bdec1a31ffcc5a65f1802ed93c04d1cf2ace68
Send DHCP notifications regardless of agent status

The Neutron service, when under load, may not be able to process
agent heartbeats in a timely fashion.  This can result in
agents being erroneously considered inactive.  Previously, DHCP
notifications for which active agents could not be found were
silently dropped.  This change ensures that notifications for
a given network are sent to agents even if those agents do not
appear to be active.

Additionally, if no enabled dhcp agents can be found for a given
network, an error will be logged.  Raising an exception might be
preferable, but has such a large testing impact that it will be
submitted as a separate patch if deemed necessary.

Partial-bug: #1192381
Change-Id: Id3e639d9cf3d16708fd66a4baebd3fbeeed3dde8
neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py
neutron/db/agents_db.py
neutron/tests/unit/api/__init__.py [new file with mode: 0644]
neutron/tests/unit/api/rpc/__init__.py [new file with mode: 0644]
neutron/tests/unit/api/rpc/agentnotifiers/__init__.py [new file with mode: 0644]
neutron/tests/unit/api/rpc/agentnotifiers/test_dhcp_rpc_agent_api.py [new file with mode: 0644]