]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
(#14463) Convert port Fixnum into strings
authorSharif Nassar <sharif@mediatemple.net>
Tue, 27 Nov 2012 19:39:59 +0000 (11:39 -0800)
committerDan Carley <dan.carley@gmail.com>
Thu, 29 Nov 2012 17:21:57 +0000 (17:21 +0000)
commit53d3ef9da087b684331601fd112f57b13f931c6a
treef9e032e071dccd1c7d127e55c6d3f81f01c561f0
parentb4ae95d0c8aad322be7744149ed853ab2770d8b8
(#14463) Convert port Fixnum into strings

Avert errors like this:
Parameter dport failed: Munging failed for value 1194 in class dport: can’t convert Fixnum into String

Also, pass along the protocol so Socket can make well informed decisions.
lib/puppet/type/firewall.rb
lib/puppet/util/firewall.rb
spec/unit/puppet/type/firewall_spec.rb
spec/unit/puppet/util/firewall_spec.rb