]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Allowed Addresspairs: Removing check for overlap with fixed ips
authorPraveen Yalagandula <ypraveen@gmail.com>
Tue, 20 May 2014 21:10:12 +0000 (21:10 +0000)
committerPraveen Yalagandula <ypraveen@gmail.com>
Wed, 21 May 2014 18:41:55 +0000 (18:41 +0000)
commit52301e4727091f867c42b18b316d4c4aacffea31
tree48ccc1b73467efb00cc3a0334f560c3b727d92ec
parentd5c0a37999f9e3a611a322baacabebc06b13283b
Allowed Addresspairs: Removing check for overlap with fixed ips

Current code does not allow assigning a fixed ip to a port when that ip
overlaps with one of the addresses in the allowed-addresspairs list.
This is an unnecessary check as the overlap does not have any negative
effect. Further, such a check actually makes it hard to use this
API. For example, if a fixed IP 10.10.1.1 exists on a port and we
want to allow addresses in 10.10.1.0/24 cidr on that port, then one
has to configure a list of 8 cidrs ([10.10.1.0/32, 10.10.1.2/31,
10.10.1.4/30, ..., 10.10.1.128/25]) on the allowed-addresspairs.
In addition to the above reasons, the current code also does not
check for the overlaps in all cases.

This patch summarily removes this overlap check.

Closes-Bug: #1321864
Change-Id: I5498c4a72b31267644da10a54a9860c1fc3bb250
neutron/db/allowedaddresspairs_db.py
neutron/plugins/bigswitch/plugin.py
neutron/plugins/ml2/plugin.py
neutron/plugins/nec/nec_plugin.py
neutron/plugins/openvswitch/ovs_neutron_plugin.py
neutron/plugins/vmware/plugins/base.py
neutron/tests/unit/test_extension_allowedaddresspairs.py