]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
netns: ip netns exec <name> kill doesn't make sense
authorIsaku Yamahata <yamahata@valinux.co.jp>
Mon, 18 Mar 2013 21:56:15 +0000 (06:56 +0900)
committerIsaku Yamahata <yamahata@valinux.co.jp>
Mon, 25 Mar 2013 06:00:48 +0000 (15:00 +0900)
commit4d72093de571c2a12dc12c3761e3bcec11ccf20e
treeaa436cc15212ce387d49963e8a70f2e707739226
parent7f814639eff66cf82fff466cec766987dcd4b51e
netns: ip netns exec <name> kill doesn't make sense

It seems confusing netns with pidns.
Although 'ip netns exec' doesn't make sense,
'ip netns exec <netns> kill <pid>' itself success as expected.
But as side effects, dentry of /proc/<pid>/ns/net becomes young,
which increases the possibility to fail to delete netns. That's not good.

Fixes: Bug #1158589
Change-Id: I9aa717ccb86d8bf00bb1e707d39bfb65d043532b
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
quantum/agent/linux/dhcp.py
quantum/agent/linux/external_process.py
quantum/plugins/services/agent_loadbalancer/drivers/haproxy/namespace_driver.py
quantum/tests/unit/services/agent_loadbalancer/driver/haproxy/test_namespace_driver.py
quantum/tests/unit/test_linux_dhcp.py
quantum/tests/unit/test_linux_external_process.py